Re: [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers

[Mark Pearson]

On Tue, Dec 23, 2025, at 2:27 PM, Benjamin Philip wrote:
> Benjamin Philip <benjamin.philip495@xxxxxxxxx> writes:
>
>> This commit replaces the uint32_t standard type with preferred u32
>> kernel type, fixing the following checkpatch check:
>>
>> CHECK: Prefer kernel type 'u32' over 'uint32_t'
>>
>> Signed-off-by: Benjamin Philip <benjamin.philip495@xxxxxxxxx>
>> ---
>>  drivers/platform/x86/lenovo/think-lmi.h | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/platform/x86/lenovo/think-lmi.h b/drivers/platform/x86/lenovo/think-lmi.h
>> index 017644323d46..6ea4bceafab2 100644
>> --- a/drivers/platform/x86/lenovo/think-lmi.h
>> +++ b/drivers/platform/x86/lenovo/think-lmi.h
>> @@ -58,19 +58,19 @@ struct tlmi_cert_guids {
>>  #define TLMI_PWDCFG_MODE_MULTICERT 3
>>
>>  struct tlmi_pwdcfg_core {
>> -	uint32_t password_mode;
>> -	uint32_t password_state;
>> -	uint32_t min_length;
>> -	uint32_t max_length;
>> -	uint32_t supported_encodings;
>> -	uint32_t supported_keyboard;
>> +	u32 password_mode;
>> +	u32 password_state;
>> +	u32 min_length;
>> +	u32 max_length;
>> +	u32 supported_encodings;
>> +	u32 supported_keyboard;
>>  };
>>
>>  struct tlmi_pwdcfg_ext {
>> -	uint32_t hdd_user_password;
>> -	uint32_t hdd_master_password;
>> -	uint32_t nvme_user_password;
>> -	uint32_t nvme_master_password;
>> +	u32 hdd_user_password;
>> +	u32 hdd_master_password;
>> +	u32 nvme_user_password;
>> +	u32 nvme_master_password;
>>  };
>>
>>  struct tlmi_pwdcfg {
>> --
>> 2.52.0
>
> I've seemed to have botched the In-Reply-To header for this email
> somehow. Please ignore. Sorry!
>
> -- bp

Looks fine
Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>

Mark