Re: [PATCH v2] arm64: dts: qcom: monaco: add QCrypto node

From: Dmitry Baryshkov

Date: Tue Dec 23 2025 - 15:23:49 EST


On Tue, Dec 23, 2025 at 12:25:18PM +0530, Abhinaba Rakshit wrote:
> Add Qualcomm Crypto Engine device node for Monaco platform.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@xxxxxxxxxxxxxxxx>
> ---
> QCE and Crypto DMA nodes patch was applied as part of the
> commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> however was partially reverted by commit cdc117c40537 ("arm64: dts:
> qcom: qcs8300: Partially revert "arm64: dts: qcom: qcs8300: add
> QCrypto nodes"") due to compatible string being miss-matched
> against schema.

^^ This looks like something that should be a part of the commit message.

>
> Resubmitting the enablement of QCE device node for monaco platform
> with compatible-string being aligned with qcom-qce schema.
>
> Bindings and Crypto DMA nodes for the same platform is already
> present in the tree.
> ---
> Changes in v2:
> - Move the description and history for the patch in cover-letter as suggested in patchset v1.
> - Use 0x0 inplace of 0x00 for iommus SMR mask field as suggested in patchset v1.
> - Link to v1: https://lore.kernel.org/r/20251222-enable-qualcomm-crypto-engine-for-monaco-v1-1-06741d6ea66a@xxxxxxxxxxxxxxxx
> ---
> arch/arm64/boot/dts/qcom/monaco.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>

--
With best wishes
Dmitry