Re: [PATCH V2 2/4] scsi: ufs: qcom: dt-bindings: Document UFSHC compatible for x1e80100

[Pradeep Pragallapati]

On 1/2/2026 4:55 PM, Krzysztof Kozlowski wrote:
> On Wed, Dec 31, 2025 at 03:49:49PM +0530, Pradeep P V K wrote:
> > Add the UFS Host Controller (UFSHC) compatible for Qualcomm x1e80100
> > SoC.  Use SM8550 as a fallback since x1e80100 shares compatibility
> > with SM8550 UFSHC, enabling reuse of existing support.
>
> Your last sentence is redundant. "Make devices compatible because they
> are compatible". Why are they compatible? Or just say that you add a new
> device fully compatible with SM8550. Write concise and informative
> statements, not long elaborted paragraphs where only few words are the
> actual information
ok, i will update in my next patchset.

> > Signed-off-by: Pradeep P V K <pradeep.pragallapati@xxxxxxxxxxxxxxxx>
> > ---
> >   .../bindings/ufs/qcom,sc7180-ufshc.yaml       | 38 +++++++++++--------
> >   1 file changed, 23 insertions(+), 15 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> > index d94ef4e6b85a..0f6ea7ca06c8 100644
> > --- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
> > @@ -26,26 +26,34 @@ select:
> >             - qcom,sm8350-ufshc
> >             - qcom,sm8450-ufshc
> >             - qcom,sm8550-ufshc
> > +          - qcom,x1e80100-ufshc
>
> You don't need this.
sure, i will update in my next patchset.
> >     required:
> >       - compatible
>
> Best regards,
> Krzysztof