Re: [PATCH 2/4] perf test: Use shelldir to refer perf source location

[Ian Rogers]

On Thu, Dec 18, 2025 at 5:18 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> It uses tools/perf/include which assumes it's running from the root of
> the linux kernel source tree.  But you can run perf from other places
> like tools/perf, then the include path won't match.  We can use the
> shelldir variable to locate the test script in the tree.
>
>   $ cd tools/perf
>
>   $ ./perf test dlfilter
>    63: dlfilter C API                                                  : Ok
>   101: perf script --dlfilter tests                                    : Ok
>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/script_dlfilter.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/script_dlfilter.sh b/tools/perf/tests/shell/script_dlfilter.sh
> index 7895ab0309b29dd5..aaed92bb78285dfd 100755
> --- a/tools/perf/tests/shell/script_dlfilter.sh
> +++ b/tools/perf/tests/shell/script_dlfilter.sh
> @@ -68,7 +68,7 @@ test_dlfilter() {
>         fi
>
>         # Build the dlfilter
> -       if ! cc -c -I tools/perf/include -fpic -x c "${dlfilter_c}" -o "${dlfilter_so}.o"
> +       if ! cc -c -I ${shelldir}/../../include -fpic -x c "${dlfilter_c}" -o "${dlfilter_so}.o"
>         then
>                 echo "Basic --dlfilter test [Skip - failed to build dlfilter object]"
>                 err=2
> --
> 2.52.0.322.g1dd061c0dc-goog
>