Re: [PATCH 1/4] perf test: Skip dlfilter test for build failures

[Ian Rogers]

On Thu, Jan 8, 2026 at 3:58 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> Ping (for the whole series)!
>
> Thanks,
> Namhyung
>
>
> On Thu, Dec 18, 2025 at 05:18:17PM -0800, Namhyung Kim wrote:
> > For some reason, it may fail to build the dlfilter.  Let's skip the test
> > as it's not an error in the perf.  This can happen when you run the perf
> > test without source code or in a different directory.
> >
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> > ---
> >  tools/perf/tests/shell/script_dlfilter.sh | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/perf/tests/shell/script_dlfilter.sh b/tools/perf/tests/shell/script_dlfilter.sh
> > index 45c97d4a7d5f90e8..7895ab0309b29dd5 100755
> > --- a/tools/perf/tests/shell/script_dlfilter.sh
> > +++ b/tools/perf/tests/shell/script_dlfilter.sh
> > @@ -70,15 +70,15 @@ test_dlfilter() {
> >       # Build the dlfilter
> >       if ! cc -c -I tools/perf/include -fpic -x c "${dlfilter_c}" -o "${dlfilter_so}.o"
> >       then
> > -             echo "Basic --dlfilter test [Failed to build dlfilter object]"
> > -             err=1
> > +             echo "Basic --dlfilter test [Skip - failed to build dlfilter object]"
> > +             err=2
> >               return
> >       fi
> >
> >       if ! cc -shared -o "${dlfilter_so}" "${dlfilter_so}.o"
> >       then
> > -             echo "Basic --dlfilter test [Failed to link dlfilter shared object]"
> > -             err=1
> > +             echo "Basic --dlfilter test [Skip - failed to link dlfilter shared object]"
> > +             err=2
> >               return
> >       fi
> >
> > --
> > 2.52.0.322.g1dd061c0dc-goog
> >