Re: [PATCH v4 3/4] usb: typec: ucsi: ucsi_glink: Add support for X1E80100 compatible string

[Bjorn Andersson]

On Thu, Jan 15, 2026 at 10:14:55AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Jan 14, 2026 at 01:17:58PM -0800, Anjelique Melendez wrote:
> > Add support for the X1E80100 compatible string which needs UCSI_DELAY_DEVICE_PDOS quirk.
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 
> 
> > 
> > Signed-off-by: Anjelique Melendez <anjelique.melendez@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c
> > index 11b3e24e34e2..e700c6a58a46 100644
> > --- a/drivers/usb/typec/ucsi/ucsi_glink.c
> > +++ b/drivers/usb/typec/ucsi/ucsi_glink.c
> > @@ -379,6 +379,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = {
> >  	{ .compatible = "qcom,sm8350-pmic-glink", .data = &quirk_sc8180x, },
> >  	{ .compatible = "qcom,sm8450-pmic-glink", .data = &quirk_sm8450, },
> >  	{ .compatible = "qcom,sm8550-pmic-glink", .data = &quirk_sm8450, },
> > +	{ .compatible = "qcom,x1e80100-pmic-glink", .data = &quirk_sm8450, },
> 
> So is it compatible with sm8550 or not? Based on this commit it would
> be, so you need to clarify here why you decided not to make them
> compatible.
> 

pmic_glink is pretty much a MFD, for this child they are compatible, but
the MFD as a whole isn't.

With the current model of naming compatible data objects by the platform
that happens to be first, this is what we get.

I find that it would be better to name the quirk objects based on what
their actual impact, something I talked with Anjelique about introducing
recently.

Regards,
Bjorn

> Best regards,
> Krzysztof
>