Re: [PATCH 3/3] mm/hugetlb: Enforce brace style

[David Hildenbrand (Red Hat)]

On 1/15/26 22:14, Joshua Hahn wrote:
> On Thu, 15 Jan 2026 21:10:41 +0100 "David Hildenbrand (Red Hat)" <david@xxxxxxxxxx> wrote:
>
> > On 1/15/26 19:14, Joshua Hahn wrote:
> > > Documentation/process/coding-style.rst explicitly notes that if only one
> > > branch of a conditional statement is a single statement, braces should
> > > be used in both branches. Enforce this in mm/hugetlb.c.
> > >
> > > No functional change intended.
> > >
> > > Signed-off-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>
> > > ---
> >
> > [...]
> >
> > >    		update_and_free_hugetlb_folio(h, folio, false);
> > >    		return rc;
> > > @@ -2672,11 +2675,13 @@ void restore_reserve_on_error(struct hstate *h, struct vm_area_struct *vma,
> > >    				 * be consumed on a subsequent allocation.
> > >    				 */
> > >    				folio_set_hugetlb_restore_reserve(folio);
> > > -		} else
> > > +		} else {
> > >    			/*
> > >    			 * No reservation present, do nothing
> > >    			 */
> > >    			 vma_end_reservation(h, vma, address);
> > > +
> >
> > But why the empty line? :)
>
> Hello David,
>
> Whoops, I totally forgot to run checkpatch on this one. I think Andrew
> also noticed this, he sent a fixlet for it. Sorry for this! I'll fix it up
> in v2.

Acked-by: David Hildenbrand (Red Hat) <david@xxxxxxxxxx>

with that ;)

--
Cheers

David