Re: [PATCH] x86/irqflags: Fix build failure

[Jürgen Groß]

On 15.01.26 18:45, Borislav Petkov wrote:
> On Thu, Jan 15, 2026 at 05:10:14PM +0100, Juergen Gross wrote:
> > When building with CONFIG_PARAVIRT, but without CONFIG_PARAVIRT_XXL,
> > a build failure might happen due to arch/x86/include/asm/irqflags.h
> > only including asm/paravirt.h when CONFIG_PARAVIRT_XXL is set.
> >
> > This was spotted when testing a patch removing the
> > "#include <asm/paravirt.h>" from another header.
> >
> > Fixes: 22cc5ca5de52 ("x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202601152203.plJOoOEF-lkp@xxxxxxxxx/
>
> So this got reported against a patchset which is not upstream yet, yet your
> Fixes: points to a patch from ~year ago.

Yes. The problem was introduced by that patch. It was pure luck paravirt.h
got included via another header.

> The right thing to do would be to take *that* fix and prepend your
> not-upstrea-yet set with it.

Yes, this would be a possibility. I still can do that, but I saw no real reason
to resend the other 5 patches without any change.

> Also, why does *this* fix need to go to all kernels which contain the patch in
> Fixes?

Whenever another patch is being backported results in the same problem, it will
be mitigated by my fix.

> All this sounds weird.

TBH I'm quite puzzled that this build failure hasn't been seen before. As I said
above: pure luck.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature