Re: [PATCH] x86/irqflags: Fix build failure

From: Borislav Petkov

Date: Thu Jan 15 2026 - 12:46:13 EST


On Thu, Jan 15, 2026 at 05:10:14PM +0100, Juergen Gross wrote:
> When building with CONFIG_PARAVIRT, but without CONFIG_PARAVIRT_XXL,
> a build failure might happen due to arch/x86/include/asm/irqflags.h
> only including asm/paravirt.h when CONFIG_PARAVIRT_XXL is set.
>
> This was spotted when testing a patch removing the
> "#include <asm/paravirt.h>" from another header.
>
> Fixes: 22cc5ca5de52 ("x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601152203.plJOoOEF-lkp@xxxxxxxxx/

So this got reported against a patchset which is not upstream yet, yet your
Fixes: points to a patch from ~year ago.

The right thing to do would be to take *that* fix and prepend your
not-upstrea-yet set with it.

Also, why does *this* fix need to go to all kernels which contain the patch in
Fixes?

All this sounds weird.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette