Re: [PATCH v7 10/10] iio: adc: qcom-spmi-iadc: Remove regmap R/W wrapper functions
From: Andy Shevchenko
Date: Wed Jan 14 2026 - 04:03:43 EST
On Wed, Jan 14, 2026 at 09:39:57AM +0100, AngeloGioacchino Del Regno wrote:
> This driver doesn't need to add any register base address to any
> regmap call anymore since it was migrated to register as a SPMI
> subdevice with its own regmap reg_base, which makes the regmap
> API to automatically add such base address internally.
>
> Since the iadc_{read,write,read_result}() functions now only do
> call regmap_{read,write,bulk_read}() and nothing else, simplify
> the driver by removing them and by calling regmap APIs directly.
...
> {
> unsigned int count, retry;
> int ret;
> - u8 sta1;
> + u32 sta1;
Keep it in reversed xmas tree order.
> retry = interval_us / IADC_CONV_TIME_MIN_US;
--
With Best Regards,
Andy Shevchenko