Re: [PATCH] drm/panel-simple: fix connector type for DataImage SCF0700C48GGU18 panel

[Neil Armstrong]

On 1/10/26 16:27, Marek Vasut wrote:
> The connector type for the DataImage SCF0700C48GGU18 panel is missing and
> devm_drm_panel_bridge_add() requires connector type to be set. This leads
> to a warning and a backtrace in the kernel log and panel does not work:
> "
> WARNING: CPU: 3 PID: 38 at drivers/gpu/drm/bridge/panel.c:379 devm_drm_of_get_bridge+0xac/0xb8
> "
> The warning is triggered by a check for valid connector type in
> devm_drm_panel_bridge_add(). If there is no valid connector type
> set for a panel, the warning is printed and panel is not added.
> Fill in the missing connector type to fix the warning and make
> the panel operational once again.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 97ceb1fb08b6 ("drm/panel: simple: Add support for DataImage SCF0700C48GGU18")
> Signed-off-by: Marek Vasut <marex@xxxxxxxxxxxx>
> ---
> Cc: David Airlie <airlied@xxxxxxxxx>
> Cc: Jessica Zhang <jesszhan0024@xxxxxxxxx>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Cc: Simona Vetter <simona@xxxxxxxx>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: kernel@xxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3acc9f3dac16a..e33ee2308e715 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1900,6 +1900,7 @@ static const struct panel_desc dataimage_scf0700c48ggu18 = {
>   	},
>   	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>   	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
>   };
>   
>   static const struct display_timing dlc_dlc0700yzg_1_timing = {

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

Thanks,
Neil