Re: [PATCH v2 04/15] rust: pin-init: internal: add utility API for syn error handling

From: Benno Lossin

Date: Tue Jan 13 2026 - 03:17:32 EST


On Mon Jan 12, 2026 at 5:14 PM CET, Gary Guo wrote:
> I don't think it's a good idea to call a type `Error` when it could just be no
> error.
>
> I think what I propose in https://lore.kernel.org/all/DFK7ITVQ97RL.2SZ2ANDIQ39H3@xxxxxxxxxxx
> is better than what's implemented here.

I don't use the fatal error, so I opted to make `emit` return unit:

https://github.com/Rust-for-Linux/pin-init/pull/89/changes/b0a242334802695342f2095657dbe62c8841eb0c

What do you think?

Cheers,
Benno