Re: [PATCH v5 04/14] ntfs: update inode operations

From: Namjae Jeon

Date: Sat Jan 17 2026 - 23:54:46 EST


On Fri, Jan 16, 2026 at 5:30 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> > int ntfs_test_inode(struct inode *vi, void *data)
> > {
> > - ntfs_attr *na = (ntfs_attr *)data;
> > - ntfs_inode *ni;
> > + struct ntfs_attr *na = (struct ntfs_attr *)data;
>
> No need to cast from void pointers to other pointer types.
Okay.
>
> > + struct ntfs_inode *ni;
> >
> > if (vi->i_ino != na->mft_no)
> > return 0;
> > +
> > ni = NTFS_I(vi);
>
> Nit: If you're touchiung this anyway, the ni initialization could be
> moved to the declaration line.
Okay, I will fix them.
Thanks!
>