Re: [PATCH v5 04/14] ntfs: update inode operations

From: Christoph Hellwig

Date: Fri Jan 16 2026 - 03:30:19 EST


> int ntfs_test_inode(struct inode *vi, void *data)
> {
> - ntfs_attr *na = (ntfs_attr *)data;
> - ntfs_inode *ni;
> + struct ntfs_attr *na = (struct ntfs_attr *)data;

No need to cast from void pointers to other pointer types.

> + struct ntfs_inode *ni;
>
> if (vi->i_ino != na->mft_no)
> return 0;
> +
> ni = NTFS_I(vi);

Nit: If you're touchiung this anyway, the ni initialization could be
moved to the declaration line.