Re: [PATCH] mailbox: pcc: Remove spurious IRQF_ONESHOT usage

[lihuisong (C)]

On 1/16/2026 10:28 PM, Sudeep Holla wrote:
> On Fri, Jan 16, 2026 at 02:07:40PM +0000, Mark Brown wrote:
> > The PCC code currently specifies IRQF_ONESHOT if the interrupt could
> > potentially be shared but doesn't actually use request_threaded_irq() and
> > the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is
> > never relevant. Since commit aef30c8d569c ("genirq: Warn about using
> > IRQF_ONESHOT without a threaded handler") specifying it has resulted in a
> > WARN_ON(), fix this by removing IRQF_ONESHOT.
> Looking back, can't think of any reason why we retained IRQF_ONESHOT
> when we added IRQF_SHARED. Thanks for spotting and fixing it.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>
The interrupt status of channel is cleared by bit first in pcc_mbox_irq.
And it is a hard irq handler.
Rmoving IRQF_ONESHOT looks good to me. Thanks for fixing it.

Acked-by: lihuisong@xxxxxxxxxx
>