Re: [PATCH] mailbox: pcc: Remove spurious IRQF_ONESHOT usage
From: Sudeep Holla
Date: Fri Jan 16 2026 - 09:28:13 EST
On Fri, Jan 16, 2026 at 02:07:40PM +0000, Mark Brown wrote:
> The PCC code currently specifies IRQF_ONESHOT if the interrupt could
> potentially be shared but doesn't actually use request_threaded_irq() and
> the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is
> never relevant. Since commit aef30c8d569c ("genirq: Warn about using
> IRQF_ONESHOT without a threaded handler") specifying it has resulted in a
> WARN_ON(), fix this by removing IRQF_ONESHOT.
>
Looking back, can't think of any reason why we retained IRQF_ONESHOT
when we added IRQF_SHARED. Thanks for spotting and fixing it.
Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>
--
Regards,
Sudeep