Re: [PATCH net-next v2 1/3] net: phy: air_en8811h: factor out shareable code

[Bjørn Mork]

Andrew Lunn <andrew@xxxxxxx> writes:

> Maybe a different strategy. Most of read_status is generic, it appears
> just reading lpa is specific to the device. So have a generic
> read_status() function, and then use phy_id_compare() to call the
> needed device specific function.

Yes, maybe that's better.  My immediate feeling was that this
contradicted your comments on the RFC, but after rereading it I see that
it doesn't.  I was reading too much into that

I'll try and see if I can improve the readability of read_status() with
a generic function.


Bjørn