Re: [PATCH net-next v2 1/3] net: phy: air_en8811h: factor out shareable code

[Andrew Lunn]

On Sun, Jan 25, 2026 at 11:51:56AM +0100, Bjørn Mork wrote:
> Andrew Lunn <andrew@xxxxxxx> writes:
> 
> > Maybe a different strategy. Most of read_status is generic, it appears
> > just reading lpa is specific to the device. So have a generic
> > read_status() function, and then use phy_id_compare() to call the
> > needed device specific function.
> 
> Yes, maybe that's better.  My immediate feeling was that this
> contradicted your comments on the RFC

Reviewers sometimes get things wrong. It is not always possible to see
everything from just the patch, and then jump to the wrong conclusion,
etc. The review process should be a conversation. We can talk about
different solutions, which might contradict earlier suggestions, as we
get a better understanding of the problem to be solved.

   Andrew