Re: [PATCH RFC 3/3] char: rttyprintk: add Rust TTY printk driver
From: Greg Kroah-Hartman
Date: Mon Jan 26 2026 - 07:53:43 EST
On Mon, Jan 26, 2026 at 12:22:10PM +0000, SeungJong Ha via B4 Relay wrote:
> + let opts = tty::Options {
> + driver_name: c_str!("rttyprintk"),
> + name: c_str!("rttyprintk"),
> + major: tty::TTYAUX_MAJOR,
> + minor_start: 4,
You are not documenting the "take over" of this minor number under this
major number anywhere, which isn't ok for using a static minor number.
And while I understand the need for an example driver, the ttyprintk
driver is a very trivial one overall, we don't need another one in the
system as one is enough :)
thanks,
greg k-h