Re: [PATCH RFC 3/3] char: rttyprintk: add Rust TTY printk driver

[하승종]

2026년 1월 26일 (월) PM 9:53, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>님이 작성:
>
> On Mon, Jan 26, 2026 at 12:22:10PM +0000, SeungJong Ha via B4 Relay wrote:
> > +        let opts = tty::Options {
> > +            driver_name: c_str!("rttyprintk"),
> > +            name: c_str!("rttyprintk"),
> > +            major: tty::TTYAUX_MAJOR,
> > +            minor_start: 4,
>
> You are not documenting the "take over" of this minor number under this
> major number anywhere, which isn't ok for using a static minor number.
>

You are correct. I should have explicitly documented the takeover
of the static minor number. I'll change it dynamic.

> And while I understand the need for an example driver, the ttyprintk
> driver is a very trivial one overall, we don't need another one in the
> system as one is enough :)
>
> thanks,
>
> greg k-h

I also agree that a duplicate driver is unnecessary. It was selected only
as the simplest candidate to validate the abstractions. I agree that
a sample driver implementation (e.g. in samples/rust/) would have
been more suitable for this purpose.

Thanks,

SeungJong Ha