Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry_priv
From: Dan Carpenter
Date: Tue Jan 27 2026 - 01:26:56 EST
On Mon, Jan 26, 2026 at 08:15:43AM -0600, Ethan Tidmore wrote:
> @@ -750,7 +751,8 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
>
> void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter)
> {
> - struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
> + struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
This is an unrelated white-space change. Don't make unrelated changes.
> + struct registry_priv *r = &Adapter->registrypriv;
I feel like you did this to avoid going over the 100 character limit,
but please do that in a separate patch. I use a script to review these
changes and I want it to be a straight s/old/new/ change. Plus, "r"
is a bad name.
regards,
dan carpenter