Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry_priv

[Ethan Tidmore]

On Mon, Jan 26, 2026 at 08:15:43AM -0600, Dan Carpenter wrote:
> This is an unrelated white-space change.  Don't make unrelated changes.
>
> > +      struct registry_priv *r = &Adapter->registrypriv;
>
> I feel like you did this to avoid going over the 100 character limit,
> but please do that in a separate patch.  I use a script to review these
> changes and I want it to be a straight s/old/new/ change.  Plus, "r"
> is a bad name.

Hi Dan,

Thanks for the review. I actually sent a v2 patchset earlier today which
should fix the whitespace issues you mentioned here.

However, I realized v2 still uses a local struct registry_priv *r shortcut
in one of the patches which is inconsistent with the rest of the series.
I will fix that in v3.

I'll wait a bit longer to see if there are any other comments on v2 before
sending the v3 series.

Thanks,
Ethan


On Tue, Jan 27, 2026 at 12:26 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Mon, Jan 26, 2026 at 08:15:43AM -0600, Ethan Tidmore wrote:
> > @@ -750,7 +751,8 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
> >
> >  void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter)
> >  {
> > -     struct hal_com_data     *pHalData = GET_HAL_DATA(Adapter);
> > +     struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
>
> This is an unrelated white-space change.  Don't make unrelated changes.
>
> > +     struct registry_priv *r = &Adapter->registrypriv;
>
> I feel like you did this to avoid going over the 100 character limit,
> but please do that in a separate patch.  I use a script to review these
> changes and I want it to be a straight s/old/new/ change.  Plus, "r"
> is a bad name.
>
> regards,
> dan carpenter
>