Re: [PATCH] gpio: pca953x: mask interrupts in irq shutdown

[Linus Walleij]

Add a few recent developers to CC, this is a very widely used GPIO chip.

Emanuele was dealing with IRQ storms and may want to look at this.

On Wed, Jan 21, 2026 at 2:12 PM Martin Larsson <martin.larsson@xxxxxxxx> wrote:

> In the existing implementation irq_shutdown does not mask the interrupts
> in hardware. This can cause spurious interrupts from the IO expander.
> Add masking to irq_shutdown to prevent spurious interrupts.
>
> Signed-off-by: Martin Larsson <martin.larsson@xxxxxxxx>
> ---
>  drivers/gpio/gpio-pca953x.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 8727ae54bc57..f93a3dbb2daa 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -914,6 +914,8 @@ static void pca953x_irq_shutdown(struct irq_data *d)
>         clear_bit(hwirq, chip->irq_trig_fall);
>         clear_bit(hwirq, chip->irq_trig_level_low);
>         clear_bit(hwirq, chip->irq_trig_level_high);
> +
> +       pca953x_irq_mask(d);

It makes sense to me.

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij