Re: [PATCH] kho: cleanup error handling in kho_populate()

From: Pratyush Yadav

Date: Tue Jan 27 2026 - 04:32:20 EST


On Thu, Jan 22 2026, Mike Rapoport wrote:

> From: "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx>
>
> * use dedicated labels for error handling instead of checking if a pointer
> is not null to decide if it should be unmapped
> * drop assignment of values to err that are only used to print a numeric
> error code, there are pr_warn()s for each failure already so printing a
> numeric error code in the next line does not add anything useful
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>

Reviewed-by: Pratyush Yadav <pratyush@xxxxxxxxxx>

[...]

--
Regards,
Pratyush Yadav