Re: [PATCH 1/2] drm: introduce page_flip_timeout()
From: Timur Kristóf
Date: Thu Jan 29 2026 - 07:06:50 EST
On Thursday, January 29, 2026 12:38:30 PM Central European Standard Time
Christian König wrote:
> >
> > However, just like we do with ring timeouts, we also need to be prepared
> > for the situation where a page flip timeout happens and we should try to
> > recover from it. And if it isn't recoverable, fall back to GPU reset.
>
> No, that is clearly a bad idea.
I don't see why it's "clearly" a bad idea. It's not clear to me at all, please
clarify it for me.
> CRTCs are fixed function devices that GPU
> reset helps here is just pure coincident.
Currently, the driver doesn't handle page flip timeouts at all, which means
that if it happens, there is 0% chance of recovering from it.
If the GPU reset improves that chance to non-zero, it's already an
improvement, and already more than what AMD did to address this problem for
the past few years. I just find it incredibly disrespectful towards the
community that AMD proposes a solution that they neglect to implement, then
when somebody from the community steps up to implement it, it's rejected.
> What we can certainly do is to improve the error handling, e.g. that the
> system doesn't sit there forever after a page flip timeout.
Sure.
>
> Let's maybe try a complete different approach. We force a page flip timeout,
> and see if the system can handle that or not.
>
> E.g. every 300 page flip we just fail to signal and see if things still work
> after the timeout.
How do you propose to do that?