Re: [PATCH 0/3] Revert "revocable: Revocable resource management"

[Laurent Pinchart]

On Thu, Jan 29, 2026 at 03:01:50PM +0000, Tzung-Bi Shih wrote:
> On Tue, Jan 27, 2026 at 03:57:44PM +0000, Tzung-Bi Shih wrote:
> > On Sat, Jan 24, 2026 at 06:05:32PM +0100, Johan Hovold wrote:
> > > Turns out there are correctness issues with both the gpiolib conversion and
> > > the revocable design itself that can lead to use-after-free and hung tasks (see
> > > [1] and patch 3/3).
> > [...]
> > > Revert the revocable implementation until a redesign has been proposed and
> > > evaluated properly.
> > 
> > I'll work on addressing the discovered issues and send follow-up fixes.  I
> > believe keeping the current series in linux-next would be beneficial, as it
> > allows for easier testing and wider evaluation by others, rather than
> > reverting at this stage.
> 
> FWIW: https://lore.kernel.org/all/20260129143733.45618-2-tzungbi@xxxxxxxxxx/
> and https://lore.kernel.org/all/20260129143733.45618-4-tzungbi@xxxxxxxxxx/
> are the proposed fixes.

I won't review that, sorry. As multiple people said in this mail thread,
the API needs to go back to the design board.

-- 
Regards,

Laurent Pinchart