Re: [PATCH] pinctrl: single: fix refcount leak in pcs_add_gpio_func()

[Linus Walleij]

On Tue, Jan 20, 2026 at 9:07 AM Wei Li <unsw.weili@xxxxxxxxx> wrote:

> of_parse_phandle_with_args() returns a device_node pointer with refcount
> incremented in gpiospec.np. The loop iterates through all phandles but
> never releases the reference, causing a refcount leak on each iteration.
>
> Add of_node_put() calls to release the reference after extracting the
> needed arguments and on the error path when devm_kzalloc() fails.
>
> This bug was detected by our static analysis tool and verified by my
> code review.
>
> Fixes: a1a277eb76b3 ("pinctrl: single: create new gpio function range")
> Cc: stable@xxxxxxxxxxxxxxx

Skipping this, it's not a critical bug.

> Signed-off-by: Wei Li <unsw.weili@xxxxxxxxx>

Patch applied.

Yours,
Linus Walleij