RE: [PATCH] HID: Intel-thc-hid: Intel-thc: Fix wrong register fields updating

From: Xu, Even

Date: Mon Feb 02 2026 - 19:35:09 EST


Thanks Jiri!

Best Regards,
Even Xu

> -----Original Message-----
> From: Jiri Kosina <jikos@xxxxxxxxxx>
> Sent: Monday, February 2, 2026 9:40 PM
> To: Xu, Even <even.xu@xxxxxxxxx>
> Cc: bentiss@xxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; linux-
> input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Zhang, Rui1
> <rui1.zhang@xxxxxxxxx>
> Subject: Re: [PATCH] HID: Intel-thc-hid: Intel-thc: Fix wrong register fields
> updating
>
> On Mon, 2 Feb 2026, Even Xu wrote:
>
> > Clear the target bit fields in register before setting new values.
> > This ensures proper field updates by removing any existing bits that
> > might interfere with the new configuration.
> >
> > Fixes: 22da60f0304b ("HID: Intel-thc-hid: Intel-thc: Introduce
> > interrupt delay control")
> > Fixes: 45e92a093099 ("HID: Intel-thc-hid: Intel-thc: Introduce max
> > input size control")
> > Signed-off-by: Even Xu <even.xu@xxxxxxxxx>
> > Tested-by: Rui Zhang <rui1.zhang@xxxxxxxxx>
>
> Applied, thanks.
>
> --
> Jiri Kosina
> SUSE Labs