Re: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure

From: Al Viro

Date: Mon Feb 02 2026 - 23:36:47 EST


On Mon, Feb 02, 2026 at 05:53:57PM +0000, Viacheslav Dubeyko wrote:
> > out_unload_nls:
> > - unload_nls(sbi->nls);
^^^^^^^^^^^^^^^^^^^^
> > unload_nls(nls);
> > - kfree(sbi);

> The patch [1] fixes the issue and it in HFS/HFS+ tree already.

AFAICS, [1] lacks this removal of unload_nls() on failure exit.
IOW, the variant in your tree does unload_nls(sbi->nls) twice...