RE: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure

[Viacheslav Dubeyko]

On Tue, 2026-02-03 at 04:38 +0000, Al Viro wrote:
> On Mon, Feb 02, 2026 at 05:53:57PM +0000, Viacheslav Dubeyko wrote:
> > >  out_unload_nls:
> > > -	unload_nls(sbi->nls);
> 	^^^^^^^^^^^^^^^^^^^^
> > >  	unload_nls(nls);
> > > -	kfree(sbi);
> 
> > The patch [1] fixes the issue and it in HFS/HFS+ tree already.
> 
> AFAICS, [1] lacks this removal of unload_nls() on failure exit.
> IOW, the variant in your tree does unload_nls(sbi->nls) twice...

Yeah, I think you are right here.

Shardul, you already spend the time on this solution. Could you please modify
your patch to fix the issue finally by correcting the patch that already in
HFS/HFS+ tree?

Thanks a lot,
Slava.