Re: [PATCH v4 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks_on()

[Konrad Dybcio]

On 2/2/26 7:09 PM, Praveen Talari wrote:
> Currently, core clk is handled individually in protocol drivers like
> the I2C driver. Move this clock management to the common clock APIs
> (geni_se_clks_on/off) that are already present in the common GENI SE
> driver to maintain consistency across all protocol drivers.
> 
> Core clk is now properly managed alongside the other clocks (se->clk
> and wrapper clocks) in the fundamental clock control functions,
> eliminating the need for individual protocol drivers to handle this
> clock separately.
> 
> Signed-off-by: Praveen Talari <praveen.talari@xxxxxxxxxxxxxxxx>
> ---

It may not be obvious from the context, but this core_clk ptr is left
uninitialized (because it'd only be assigned with geni_se_resources_init()
introduced in the previous patch, which is not called at this point)
so everything works out

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad