Re: [PATCH v3 2/2] hwmon: add support for MCP998X

[Guenter Roeck]

On Tue, Jan 27, 2026 at 05:18:22PM +0200, victor.duicu@xxxxxxxxxxxxx wrote:
> From: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>
> 
> This is the driver for Microchip MCP998X/33 and MCP998XD/33D
> Multichannel Automotive Temperature Monitor Family.
> 
> Signed-off-by: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>
> ---

More feedback, with compliments from Gemini :-).

[ ... ]

> +	case hwmon_temp:
> +		switch (attr) {
> +		case hwmon_temp_max:
> +			if (channel)
> +				addr = MCP9982_EXT_HIGH_LIMIT_ADDR(channel);
> +			else
> +				addr = MCP9982_INTERNAL_HIGH_LIMIT_ADDR;
> +
> +			return ret = mcp9982_write_limit(priv, addr, val);

Pointless assignment to ret.

Thanks,
Guenter