Re: [PATCH v3 2/2] hwmon: add support for MCP998X

[Guenter Roeck]

On Tue, Jan 27, 2026 at 05:18:22PM +0200, victor.duicu@xxxxxxxxxxxxx wrote:
> From: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>
> 
> This is the driver for Microchip MCP998X/33 and MCP998XD/33D
> Multichannel Automotive Temperature Monitor Family.
> 
> Signed-off-by: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>

Gemini is having fun. Another good point.

> +#define MCP9982_HIGH_LIMIT_DEFAULT		21000

AI:
The default high limit of 21 degrees C is extremely low and likely to cause
immediate alarms on many systems (e.g., room temperature is often > 21C,
and inside a case it is almost certainly higher). Standard practice is to
leave limits as configured by BIOS/firmware, or set them to the chip's
maximum rating if unconfigured. Overwriting them unconditionally to 21C
is a regression in expected behavior and usability.

Me: I would not call this a regression, but Gemini does have a point.
Why such a low high limit ? At the very least that warrants an
explanation/comment.

Thanks,
Guenter