Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT

[Konrad Dybcio]

On 1/31/26 11:31 AM, Roger Shimizu wrote:
> Thundercomm AI MiniPC G1 IoT is single board computer with
> AI capability based on Qualcomm QCS6490 platform.
> 
> This device tree is confirmed to work as below:
> - GPU
> - HDMI output port
> - PCIe M.2 port (for external Wi-Fi or 5G connectivity)
> - UART / serial console port
> - UFS
> - USB Type-C port, with Display Port
> 
> Signed-off-by: Roger Shimizu <rosh@xxxxxxxxxx>
> ---

[...]

> +/ {
> +	model = "Thundercomm AI Mini PC G1 IoT";
> +	compatible = "qcom,sc7280", "qcom,qcm6490";

You need to add a board-specific compatible here, see:

Documentation/devicetree/bindings/arm/qcom.yaml

> +	chassis-type = "embedded";

The allowed values are:

    enum:
      - desktop
      - laptop
      - convertible
      - server
      - all-in-one
      - tablet
      - handset
      - watch
      - embedded
      - television
      - spectacles

I think it's more of a desktop, but a) that's minor and b) you could
argue either way

[...]

> +		vreg_s1b_1p872: smps1 {
> +			regulator-name = "vreg_s1b_1p872";
> +			regulator-min-microvolt = <1840000>;
> +			regulator-max-microvolt = <2040000>;

Have you cross-checked the regulator settings against the original
vendor-provided sw?

[...]

> +&gpu_zap_shader {
> +	firmware-name = "qcom/qcs6490/a660_zap.mbn";

I'm assuming this means the thing can take Qualcomm- (vs OEM-)signed firmware
Could you please confirm that's the case?

[...]

> +&pon_pwrkey {
> +	status = "okay";
> +};

This one is already enabled

Konrad