Re: [PATCH v4 next 5/6] iio: sca3000: stop interrupts via devm_add_action_or_reset()

[Harshit Mogalapalli]

Hi Andy,

On 04/02/26 14:31, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 10:12:00PM -0800, Harshit Mogalapalli wrote:
> > sca3000_stop_all_interrupts() is moved above the probe routine so the
> > new function sca3000_disable_interrupts() used in probe can directly
> > call it without additional declaration.
> >
> > Used devm_add_action_or_reset() for shutting down the interrupts.
> > Make sca3000_stop_all_interrupts() return void now that it always hooks
> > into devm cleanup.
> >
> > No functional change intended.
>
> This patch overloaded by extra thing. What you should do is just move code
> upper without _any_ modifications being done _before_ even patching it for
> guard()(). With that additional patch the rest will look much easier to
> review.

I agree, thanks a lot for the suggestions!

Regards,
Harshit