Re: [PATCH] tof: Add VL53L4CX TOF drivers

[Waqar Hameed]

On Sat, Feb 07, 2026 at 17:42 +0800 434779359@xxxxxx wrote:

> From: liufulin <frank.liu@xxxxxxxxx>
>
> This patch adds support for the vl53l4cx tof ic
> ICs used in Qualcomm reference designs
>
> Signed-off-by: liufulin <frank.liu@xxxxxxxxx>

[...]

Many of my initial comments have already been stated by Jonathan and
Andy. I still want to emphasize to run `scripts/checkpatch.pl` on your
patches (this one has 6761 errors and 11804 warnings...) before sending
them. (Shouldn't we have CI jobs for this?).

Some other general comments: please include a description of the device
and the chosen driver design. The linked datasheet doesn't explain all
the functionality used in this driver ([1] mentions some "host API"?).
Moreover, it seems like this driver is not originally written by you (by
looking at the copyright headers) and thus has some history that might
need some explanation?

[1] ch 3, p. 6, https://www.st.com/resource/en/datasheet/vl53l0x.pdf