Re: [PATCH] tof: Add VL53L4CX TOF drivers
From: Andy Shevchenko
Date: Sat Feb 14 2026 - 13:20:14 EST
On Sat, Feb 14, 2026 at 04:25:26PM +0000, Jonathan Cameron wrote:
> On Sun, 8 Feb 2026 15:13:23 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Sat, Feb 07, 2026 at 01:49:50PM +0000, Jonathan Cameron wrote:
> > > On Sat, 7 Feb 2026 17:42:35 +0800
> > > 434779359@xxxxxx wrote:
...
> > Yeah, this is even barely satisfies requirement to put into staging/iio.
>
> Just to cut off any chance of wrong interpretation: We don't put new devices
> through staging/iio any more. There is little reason to do so now that the core
> is out of there and mass refactors and ABI changes are a thing of the distant
> past.
>
> Now it's much swifter to clean a driver up on list.
>
> Maybe there is a reason we might consider drivers/staging again for IIO
> device drivers, but I've not thought of it yet!
Depends on the quality of the driver and eagerness to have it in the kernel.
> > It has so-o-o many style issues and other small things (I just pressed PgDn
> > several times within 5 seconds). You need to take your time and invest into:
> > - creating an upstream plan (roadmap)
> > - as Jonathan said, start with a minimalistic setup (not more than a couple of
> > thousands of LoCs
> > - be sure the style follows the Coding Style and IIO subsystem specifics
> > - be sure the code uses modern APIs from kernel and not some outdated stuff
--
With Best Regards,
Andy Shevchenko