Re: [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo PHY configuration values
From: Yongxing Mou
Date: Tue Feb 10 2026 - 05:17:23 EST
On 2/9/2026 8:47 PM, Dmitry Baryshkov wrote:
On Mon, Feb 09, 2026 at 05:52:22PM +0800, Yongxing Mou wrote:Hi, do you mean the second LDO patch should come before the first patch？In fact, maybe three patches should go into the stable branch. The LDO patch cannot be used on its own. On both sa8775p and hamoa, their eDP/DP modes do not match the tables they are currently using (hamoa should use the eDP table, while sa8775p should use the DP table). If only the LDO patch is applied, it may cause link training to fail.
On 2/7/2026 6:22 PM, Dmitry Baryshkov wrote:
On Thu, Feb 05, 2026 at 05:20:53PM +0800, Yongxing Mou wrote:Sure. got it thanks, will remove "This patch".
According to the current HPG settings, most eDP/DP combo PHYs can reuse the
same configuration values.
DP mode：
-sa8775p/sc7280/sc8280xp/x1e80100
-glymur
eDP mode(low vdiff):
-glymur/sa8775p/sc8280xp/x1e80100
-sc7280
The current driver still keeps multiple versions of these tables and
doesn't fully support every combo PHY mode. This patch removes the
See Documentation/process/submitting-patches.rst, "This patch".
Hi, if this would help with your review work, I’m very happy to do it.redundant configs and keeps only the sets we actually use, matching the
platforms listed above.
Should it be combined with the 3rd patch? There you sort out all the
tables, it makes more sense to review all programming together.
My original intention was to do some cleanup in this patch—correct the table
values so that more platforms can reuse the same table.
Fixed should come before cleanups (so that they can be backported to
stable kernels).
Sure.From Konard’s comments, it seems that the HPG table may not be the most
appropriate one either.
Maybe shoud first determine what the correct table values should be.
Please follow the tables for each SKU separately (that's the 'fix'
part).