Re: [PATCH 2/8] dt-bindings: interrupt-controller: add LS7A PCH LPC

[Icenowy Zheng]

在 2026-02-09星期一的 17:48 -0600，Rob Herring写道：
> On Sat, Jan 31, 2026 at 05:45:41PM +0800, Icenowy Zheng wrote:
> > Loongson 7A series PCH contains an LPC controller with an interrupt
> > controller.
> > 
> > Add the device tree binding for the interrupt controller.
> > 
> > Signed-off-by: Icenowy Zheng <zhengxingda@xxxxxxxxxxx>
> > ---
> >  .../loongson,pch-lpc.yaml                     | 52
> > +++++++++++++++++++
> >  1 file changed, 52 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-
> > controller/loongson,pch-lpc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-
> > controller/loongson,pch-lpc.yaml
> > b/Documentation/devicetree/bindings/interrupt-
> > controller/loongson,pch-lpc.yaml
> > new file mode 100644
> > index 0000000000000..c00fbf31f47f0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-
> > controller/loongson,pch-lpc.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/interrupt-controller/loongson,pch-lpc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Loongson PCH LPC Controller
> > +
> > +maintainers:
> > +  - Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> > +
> > +description:
> > +  This interrupt controller is found in the Loongson LS7A family
> > of PCH for
> > +  accepting interrupts sent by LPC-connected peripherals and
> > signalling PIC
> > +  via a single interrupt line when interrupts are available.
> > +
> > +properties:
> > +  compatible:
> > +    const: loongson,pch-lpc-1.0
> 
> Where does 1.0 come from? We don't do version numbers generally
> unless 
> you define where the versions come from (e.g. Soft IP releases for 
> FPGAs). I would have expected "ls7a" in the compatible instead.

I originally followed the behavior of PCH PIC; however after asking
Jiaxun offlist, I was noticed about a register on the 7A1000 user
manual in the PIC that identifies the PIC version number; such version
number register does not exist for LPC part.

I will switch to ls7a-lpc or ls7a1000-lpc. Newer compatible strings in
the 2K series (LoongArch ones) come with the whole model number, I
don't know whether this is needed for 7A1000 (although it looks like
that 7A2000 has the same 
> 
> Rob
>