Re: [PATCH v2 1/9] dt-bindings: misc: document ASUS Transformers EC DockRAM

From: Krzysztof Kozlowski

Date: Tue Feb 10 2026 - 05:50:52 EST


On 10/02/2026 10:42, Svyatoslav Ryhel wrote:
> вт, 10 лют. 2026 р. о 11:25 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
>>
>> On Mon, Feb 09, 2026 at 12:43:59PM +0200, Svyatoslav Ryhel wrote:
>>> Documenting an I2C device used in conjunction with the EC on ASUS
>>> Transformers. The main function of DockRAM (the name used by downstream
>>> ASUS sources) is to provide power-related functions, such as battery and
>>> charger communication. The device is exposed as an individual entity
>>> because multiple embedded controllers can utilize the same DockRAM
>>> instance.
>>>
>>> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
>>> ---
>>> .../bindings/misc/asus,dockram.yaml | 40 +++++++++++++++++++
>>> 1 file changed, 40 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/misc/asus,dockram.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/misc/asus,dockram.yaml b/Documentation/devicetree/bindings/misc/asus,dockram.yaml
>>> new file mode 100644
>>> index 000000000000..0cfde619ba01
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/misc/asus,dockram.yaml
>>
>> Not a misc device. Find appropriate place, e.g. for EC or docking or
>> laptop devices or power-related.
>>
>
> Why not misc? be more specific pls where you want it to be.

Because there is no such device as "misc". Otherwise explain me what
sort of device is "misc".

I already wrote where I want it to be placed. You keep bouncing
questions pointlessly, even when given exact request.



>
>>> @@ -0,0 +1,40 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/misc/asus,dockram.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Asus Transformer EC DockRAM
>>> +
>>> +maintainers:
>>> + - Svyatoslav Ryhel <clamor95@xxxxxxxxx>
>>> +
>>> +description:
>>> + Dedicated i2c device used to provide power related functions of the
>>> + embedded controller used in ASUS Transformer device family.
>>> +
>>> +properties:
>>> + compatible:
>>> + const: asus,dockram
>>
>> Way too generic compatible. You are not documenting here all ASUS
>> laptops/devices dockram. For example this implies dockram is also on
>> ASUS Vivobook... or on any other asus device.
>>
>
> Asus were not so generous to provide more specific data, they call
> this device dockram in their sources.



>
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> +
>>
>> Device looks weirdly empty. Probably you have it only to instantiate I2C
>> handle, so what you really wanted is i2c-parent. This is not a real
>> device.
>>
>
> WDYM? it is a real physical i2c device located on a i2c bus and probed
> by i2c driver just fine. Maybe you will deny RTC being a real device

Driver does not matter here.

> like it was done for example for max77663 which now causes a massive
> issues since it can occupy different i2c addresses?

Then describe what is the device here. So far it looks exactly like
"ec-dock" for which you already have a binding.

Best regards,
Krzysztof