Re: [PATCH] fbnic: close fw_log race between users and teardown

[Chengfeng Ye]

On Wed, Feb 11, 2026 at 1:24 AM Alexander H Duyck
<alexander.duyck@xxxxxxxxx> wrote:
> A better fix for this might be to pull out fbnic_fw_log_enable/disable
> from the fw_log_init/free and leave them in the places currently
> occupied by the fw_log_init/free calls. With that we could place the
> log_init before the request_mbx call, add fw_log_free as an exception
> case before "free_irqs", and relocate fw_log_free to the line after the
> fw_free_mbx calls as it is a resource that should be put in place
> before the mailbox is enabled, and not cleared until after the mailbox
> and debugfs file has been disabled.

Looks great, adjusting the order of existing synchronization is much
better than adding new locking. I will send a new patch soon.

Thanks,
Chengfeng