Re: [PATCH v3] apple-gmux: preserve brightness using EFI

Next message: Sasha Levin: "[PATCH AUTOSEL 6.19-5.10] sparc: Synchronize user stack on fork and clone"
Previous message: Thomas Wei&#xDF;schuh: "Re: arch/x86/include/uapi/../../../../lib/vdso/gettimeofday.c:308 __cvdso_clock_gettime_common() warn: right shifting more than type allows 32 vs 40"
In reply to: Hans de Goede: "Re: [PATCH v3] apple-gmux: preserve brightness using EFI"
Next in thread: Hans de Goede: "Re: [PATCH v3] apple-gmux: preserve brightness using EFI"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Atharva Tiwari

Date: Wed Feb 11 2026 - 07:30:33 EST

> I think this is missing efivar_lock() + unlock() calls ?

actually, efivar_set_variable already holds the lock, so efivar_lock isint
required.

See: drivers/firmware/efi/vars.c:242 and drivers/firmware/efi/vars.c:184