Re: [PATCH v3] apple-gmux: preserve brightness using EFI

[Hans de Goede]

Hi,

On 11-Feb-26 13:30, Atharva Tiwari wrote:
>> I think this is missing efivar_lock() + unlock() calls ?
> 
> actually, efivar_set_variable already holds the lock, so efivar_lock isint
> required.
> 
> See: drivers/firmware/efi/vars.c:242 and drivers/firmware/efi/vars.c:184

Ah I did not know that, that is somewhat inconsistent but not
a problem with this patch:

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@xxxxxxxxxxxxxxxx>

Regards,

Hans