RE: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header

[Luck, Tony]

> But we basically never care about the format that's in CPUID.01H:EAX.

> The PECI code has none of that. It's *just* matching the "id" of the
> device to the "id" of the CPU. It just so happens that the "id" that's
> chosen matches CPUID.01H:EAX.

> So PECI and x86 both want the same data, but they do very different
> things with it.

> So let's just duplicate the constants. Completely untested patch attached.

> Any reason not to do this?

PECI code doesn't care about the stepping. You drop it when initializing
the device_id:

+	device->info.device_id = cpu_id >> 4;

But then you defined all the PECI model constants with the stepping.
E.g.

+#define PECI_INTEL_HASWELL_X		0x306C0

Perhaps drop the trailing '0' nibble and add a comment about the ID
being stepping independent?

-Tony