Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header

[Dave Hansen]

On 2/11/26 14:35, Sohil Mehta wrote:
> On 2/11/2026 2:32 PM, Luck, Tony wrote:
>>>> +	device->info.device_id = cpu_id >> 4;
>>>>  
>>> I imagine this shifting the stepping. Should this be cpu_id & 0xF?
>> Fixing here seems to be better than changing the constants. But needs a "~"
>>
>> 	/* Ignore the stepping */
>> 	device->info.device_id = cpu_id & ~ 0xF;
>>
> Ah, yes! Error while fixing an error 🙂

Nice catches guys, and thanks for this! I do think masking it like that
is the right thing to do... unless that field that comes off the device
in peci_device_info_init() is always 0's.

There are apparently no public PECI docs so it's hard to tell what the
rules for that field are.