Re: [PATCH v5 2/4] x86/mm/pat: Convert pte code to use ptdescs

[Dave Hansen]

On 2/11/26 14:23, Vishal Moola (Oracle) wrote:
> On Wed, Feb 11, 2026 at 09:55:51PM +0000, Matthew Wilcox wrote:
>> On Wed, Feb 11, 2026 at 11:52:31AM -0800, Vishal Moola (Oracle) wrote:
>>> -static bool try_to_free_pte_page(pte_t *pte)
>>> +static bool try_to_free_pte(pte_t *pte)
>> I don't like this name though.  You're not freeing a single PTE,
>> you're freeing a level of page tables.  How about
>> try_to_free_pte_table()?
> Ah, right. That would make sense to me.
> 
> Dave doesn't want the renaming at all[1], so I'm planning to leave it as
> try_to_free_pte_page() though.

Let's just talk about renaming later, please. I'm not totally against
it, but there is enough going on in this set already.