Re: [PATCH v5 2/4] x86/mm/pat: Convert pte code to use ptdescs
From: Vishal Moola (Oracle)
Date: Wed Feb 11 2026 - 17:24:26 EST
On Wed, Feb 11, 2026 at 09:55:51PM +0000, Matthew Wilcox wrote:
> On Wed, Feb 11, 2026 at 11:52:31AM -0800, Vishal Moola (Oracle) wrote:
> > -static bool try_to_free_pte_page(pte_t *pte)
> > +static bool try_to_free_pte(pte_t *pte)
>
> I don't like this name though. You're not freeing a single PTE,
> you're freeing a level of page tables. How about
> try_to_free_pte_table()?
Ah, right. That would make sense to me.
Dave doesn't want the renaming at all[1], so I'm planning to leave it as
try_to_free_pte_page() though.
[1] https://lore.kernel.org/linux-mm/20260211195233.368497-1-vishal.moola@xxxxxxxxx/T/#m72f1d8d91b16f0693cca4271cc8685d2337372d7