Re: [PATCH 00/22] dm-verity: more FEC fixes and cleanups

[Sami Tolvanen]

Hi Eric,

On Thu, Feb 5, 2026 at 9:01 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> This series applies to linux-dm/for-next.  It can also be retrieved from:
>
>     git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git dm-verity-fec-2026-02-05
>
> Patches 1-5 fix bugs in dm-verity's forward error correction (FEC):
>
> - FEC and hash devices that are too small were not rejected.
>
> - Corrected blocks could be multiple-counted in statistics.
>
> - The erasures array was significantly oversized for its use case.
>
> - An out-of-bounds read could occur when decoding an RS codeword whose
>   parity bytes span a block boundary.

Thanks for the fixes, these look correct to me. It would be nice to
have tests for the edge cases though. Perhaps in the
verity-compat-test script that's included in the cryptsetup repo?

> Patches 6-22 clean up the FEC implementation to be easier to understand
> and improve documentation and log messages.

The clean-ups also look reasonable. For the series:

Reviewed-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>

Sami