Re: [PATCH 1/3] media: i2c: imx283: Report correct V4L2_SEL_TGT_CROP

[Kieran Bingham]

Quoting Kieran Bingham (2025-09-18 14:27:51)
> From: Stefan Klug <stefan.klug@xxxxxxxxxxxxxxxx>
> 
> The target crop rectangle is initialized with the crop of the default
> sensor mode. This is incorrect when a different sensor mode gets
> selected. Fix that by updating the crop rectangle when changing the
> sensor mode.

This seems good to me and tests well.

It's arbitrary but perhaps we should add this:

Fixes: ccb4eb4496fa ("media: i2c: Add imx283 camera sensor driver")
Cc: stable@xxxxxxxxxxxxxxx # v6.10-rc1-70-gccb4eb4496fa


Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
Tested-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>


> 
> Signed-off-by: Stefan Klug <stefan.klug@xxxxxxxxxxxxxxxx>
> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/imx283.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/i2c/imx283.c b/drivers/media/i2c/imx283.c
> index 67e8bb432d10..06c4b01868c0 100644
> --- a/drivers/media/i2c/imx283.c
> +++ b/drivers/media/i2c/imx283.c
> @@ -956,6 +956,7 @@ static int imx283_set_pad_format(struct v4l2_subdev *sd,
>                                  struct v4l2_subdev_state *sd_state,
>                                  struct v4l2_subdev_format *fmt)
>  {
> +       struct v4l2_rect *crop;
>         struct v4l2_mbus_framefmt *format;
>         const struct imx283_mode *mode;
>         struct imx283 *imx283 = to_imx283(sd);
> @@ -982,6 +983,9 @@ static int imx283_set_pad_format(struct v4l2_subdev *sd,
>  
>         *format = fmt->format;
>  
> +       crop = v4l2_subdev_state_get_crop(sd_state, IMAGE_PAD);
> +       *crop = mode->crop;
> +
>         return 0;
>  }
>  
> -- 
> 2.50.1
>