Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Neeraj Soni]

On 2/6/2026 4:56 PM, Krzysztof Kozlowski wrote:
> On 06/02/2026 12:20, Neeraj Soni wrote:
>> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
>> So add the qcom,ice property to reference it.
>>
>> Co-developed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
>> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
>> Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Neeraj Soni <neeraj.soni@xxxxxxxxxxxxxxxx>
>>
>> ---
>>
>> Some initial work is done by Abel here:
>> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@xxxxxxxxxx/
>> and by Abhinaba here:
>> https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@xxxxxxxxxxxxxxxx/
>>
>> This patch adds the purpose and usage for phandle in the description and encodes
>> it properly in the schema.
>> ---
>>  .../devicetree/bindings/mmc/sdhci-msm.yaml    | 26 +++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> index 938be8228d66..f35b675c9f16 100644
>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> @@ -140,6 +140,12 @@ properties:
>>      $ref: /schemas/types.yaml#/definitions/uint32
>>      description: platform specific settings for DLL_CONFIG reg.
>>  
>> +  qcom,ice:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: |
>> +      phandle to the Inline Crypto Engine node. ICE having its own platform driver will use this phandle to
> 
> Please wrap code according to the preferred limit expressed in Kernel
> coding style (checkpatch is not a coding style description, but only a
> tool).  However don't wrap blindly (see Kernel coding style).
>
Sure. While executing dt_binding_check the tool reported max limit as 110 characters so i wrapped
around it. I will consolidate the description to single line in next patch.
 
> Do not need '|' unless you need to preserve formatting.
> 
Ack. I will limit the description to single line.
> 
> I do not understand the platform driver reference here. You are supposed
> to explain how the hardware uses it, for what purpose. If I change Linux
> to use auxilary driver, then the binding is incorrect?
> 
> 
>> +      manage its resources independently. Either add this phandle or ICE address space for ICE to work.
> 
> Don't repeat constraints in free form text>
Ack. Will fix in next patch.
 
> Such trivialities should not happen, I am sometimes skipping deep dive
> review, so I skipped the rest.
> 
> :
> 
> 
> Best regards,
> Krzysztof
> 
Best Regards,
Neeraj